[ https://issues.apache.org/jira/browse/THRIFT-5533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500387#comment-17500387 ]
Jens Geyer commented on THRIFT-5533: ------------------------------------ [00:04:25] > Task :compileJava [00:04:25] C:\projects\thrift\lib\java\src\org\apache\thrift\transport\THttpClient.java:39: warning: [deprecation] CoreConnectionPNames in org.apache.http.params has been deprecated [00:04:25] import org.apache.http.params.CoreConnectionPNames; [00:04:25] ^ [00:04:27] C:\projects\thrift\lib\java\src\org\apache\thrift\transport\THttpClient.java:165: warning: [deprecation] CoreConnectionPNames in org.apache.http.params has been deprecated [00:04:27] client.getParams().setParameter(CoreConnectionPNames.CONNECTION_TIMEOUT, connectTimeout_); [00:04:27] ^ [00:04:27] C:\projects\thrift\lib\java\src\org\apache\thrift\transport\THttpClient.java:165: warning: [deprecation] getParams() in HttpClient has been deprecated [00:04:27] client.getParams().setParameter(CoreConnectionPNames.CONNECTION_TIMEOUT, connectTimeout_); [00:04:27] ^ [00:04:27] C:\projects\thrift\lib\java\src\org\apache\thrift\transport\THttpClient.java:174: warning: [deprecation] CoreConnectionPNames in org.apache.http.params has been deprecated [00:04:27] client.getParams().setParameter(CoreConnectionPNames.SO_TIMEOUT, readTimeout_); [00:04:27] ^ [00:04:27] C:\projects\thrift\lib\java\src\org\apache\thrift\transport\THttpClient.java:174: warning: [deprecation] getParams() in HttpClient has been deprecated [00:04:27] client.getParams().setParameter(CoreConnectionPNames.SO_TIMEOUT, readTimeout_); [00:04:27] ^ [00:04:27] Note: Some input files use unchecked or unsafe operations. [00:04:27] Note: Recompile with -Xlint:unchecked for details. [00:04:27] 5 warnings > Fix Java warnings: @param, @return and deprecation > -------------------------------------------------- > > Key: THRIFT-5533 > URL: https://issues.apache.org/jira/browse/THRIFT-5533 > Project: Thrift > Issue Type: Improvement > Components: Java - Library > Reporter: Jens Geyer > Priority: Major > > [00:31:18] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\EnumCache.java:55: > warning: no @return > [00:31:18] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\ThriftMetadata.java:120: > warning: no @param for level > [00:31:18] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\ThriftMetadata.java:120: > warning: no @return > [00:31:18] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\ThriftMetadata.java:127: > warning: no @param for sb > [00:31:18] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\ThriftMetadata.java:127: > warning: no @param for format > [00:31:18] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\ThriftMetadata.java:127: > warning: no @param for args > [00:31:18] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\ThriftMetadata.java:134: > warning: no @return > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:39: > warning: no @param for obj > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:39: > warning: no @param for argName > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:46: > warning: no @param for value > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:46: > warning: no @param for argName > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:53: > warning: no @param for value > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:53: > warning: no @param for argName > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:67: > warning: no @param for isValid > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:67: > warning: no @param for argName > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:74: > warning: no @param for isValid > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:74: > warning: no @param for argName > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:74: > warning: no @param for validValues > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:81: > warning: no @param for arg > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:81: > warning: no @param for argName > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:92: > warning: no @param for <T> > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:92: > warning: no @param for array > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:92: > warning: no @param for argName > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:100: > warning: no @param for array > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:100: > warning: no @param for argName > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:108: > warning: no @param for array > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:108: > warning: no @param for argName > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:116: > warning: no @param for array > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:116: > warning: no @param for argName > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:124: > warning: no @param for array > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:124: > warning: no @param for argName > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:132: > warning: no @param for <T> > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:132: > warning: no @param for iter > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:132: > warning: no @param for argName > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:141: > warning: no @param for <T> > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:141: > warning: no @param for collection > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:141: > warning: no @param for numElements > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:141: > warning: no @param for argName > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:156: > warning: no @param for value1 > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:156: > warning: no @param for value1Name > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:156: > warning: no @param for value2 > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:156: > warning: no @param for value2Name > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:173: > warning: no @param for value1 > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:173: > warning: no @param for value1Name > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:173: > warning: no @param for value2 > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:173: > warning: no @param for value2Name > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:190: > warning: no @param for value1 > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:190: > warning: no @param for value1Name > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:190: > warning: no @param for value2 > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:190: > warning: no @param for value2Name > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:207: > warning: no @param for value1 > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:207: > warning: no @param for value1Name > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:207: > warning: no @param for value2 > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:207: > warning: no @param for value2Name > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:224: > warning: no @param for value1 > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:224: > warning: no @param for value1Name > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:224: > warning: no @param for value2 > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:224: > warning: no @param for value2Name > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:241: > warning: no @param for value > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:241: > warning: no @param for valueName > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:241: > warning: no @param for minValueInclusive > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:241: > warning: no @param for maxValueInclusive > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:258: > warning: no @param for value > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:258: > warning: no @param for valueName > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:258: > warning: no @param for minValueInclusive > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\partial\Validate.java:258: > warning: no @param for maxValueInclusive > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\TDeserializer.java:90: > warning: no @throws for org.apache.thrift.transport.TTransportException > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\TDeserializer.java:113: > warning: no @throws for org.apache.thrift.transport.TTransportException > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TEndpointTransport.java:45: > warning: no description for @param > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TEndpointTransport.java:47: > warning: no @throws for org.apache.thrift.transport.TTransportException > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TEndpointTransport.java:67: > warning: no description for @param > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TEndpointTransport.java:77: > warning: no description for @param > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TEndpointTransport.java:86: > warning: no description for @param > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TEndpointTransport.java:88: > warning: no @throws for org.apache.thrift.transport.TTransportException > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\AutoExpandingBufferWriteTransport.java:44: > warning: no @throws for org.apache.thrift.transport.TTransportException > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TFileTransport.java:602: > warning: no @param for args > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TFileTransport.java:602: > warning: no @throws for java.lang.Exception > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TTransportFactory.java:37: > warning: no @throws for org.apache.thrift.transport.TTransportException > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TIOStreamTransport.java:60: > warning: no @throws for org.apache.thrift.transport.TTransportException > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TIOStreamTransport.java:79: > warning: no @throws for org.apache.thrift.transport.TTransportException > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TIOStreamTransport.java:124: > warning: no @throws for org.apache.thrift.transport.TTransportException > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TIOStreamTransport.java:100: > warning: no @throws for org.apache.thrift.transport.TTransportException > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TIOStreamTransport.java:52: > warning: no @param for config > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TIOStreamTransport.java:52: > warning: no @throws for org.apache.thrift.transport.TTransportException > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TIOStreamTransport.java:67: > warning: no description for @param > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TIOStreamTransport.java:70: > warning: no @throws for org.apache.thrift.transport.TTransportException > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TIOStreamTransport.java:108: > warning: no description for @param > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TIOStreamTransport.java:112: > warning: no @throws for org.apache.thrift.transport.TTransportException > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TIOStreamTransport.java:87: > warning: no description for @param > [00:31:19] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TIOStreamTransport.java:90: > warning: no @throws for org.apache.thrift.transport.TTransportException > [00:31:20] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TNonblockingServerSocket.java:63: > warning: no @param for port > [00:31:20] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TNonblockingServerSocket.java:63: > warning: no @throws for org.apache.thrift.transport.TTransportException > [00:31:20] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TNonblockingServerSocket.java:70: > warning: no @param for port > [00:31:20] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TNonblockingServerSocket.java:70: > warning: no @param for clientTimeout > [00:31:20] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TNonblockingServerSocket.java:70: > warning: no @throws for org.apache.thrift.transport.TTransportException > [00:31:20] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TNonblockingSocket.java:102: > warning: no description for @param > [00:31:20] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TNonblockingSocket.java:125: > warning: no @return > [00:31:20] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TNonblockingTransport.java:39: > warning: no @return > [00:31:20] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TNonblockingTransport.java:39: > warning: no @throws for java.io.IOException > [00:31:20] > C:\projects\thrift\lib\java\src\org\apache\thrift\transport\TNonblockingTransport.java:45: > warning: no @return > [00:31:21] 100 warnings -- This message was sent by Atlassian Jira (v8.20.1#820001)