[ 
https://issues.apache.org/jira/browse/THRIFT-5541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514923#comment-17514923
 ] 

Yuxuan Wang commented on THRIFT-5541:
-------------------------------------

This is [clearly defined in the 
spec|https://github.com/apache/thrift/blob/f0336417cae1c32f4ea59a9f9851a15f269340f7/doc/specs/HeaderFormat.md?plain=1#L80-L81]
 as:
{noformat}
key/value pairs of varstrings (varint16 length plus no-trailing-null 
string).{noformat}
I'm not sure which part of that is ambiguous.

> Header spec is ambiguous about key format
> -----------------------------------------
>
>                 Key: THRIFT-5541
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5541
>             Project: Thrift
>          Issue Type: Documentation
>            Reporter: Marco Ferrer
>            Priority: Minor
>
> The current header specification does not specify what is considered a valid 
> format for keys. Looking at the most common networking protocols (http/http2) 
> we see specifics as to what keys characters are allowed and their formatting. 
> There is no equivalent definition in thrift. 
> The thrift header spec should clarify things like case sensitivity, behavior 
> for trailing whitespace and non-ascii characters. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to