[ https://issues.apache.org/jira/browse/THRIFT-5548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17518469#comment-17518469 ]
Jens Geyer commented on THRIFT-5548: ------------------------------------ A few questions and hints I have. The questions are just that, questions. My Java practice is limited and I have not read the entire PR yet. * If we can leverage Java compiler/libraries, why not use the existing code and add any specialties needed via switch? In other words, what value does the duplicated code add that we would miss otherwise? * The files should all have a proper ASF license header. There is a wild mixture of all kinds of license headers and I also have seen files without. That needs to be fixed before it can be merged. If there is any third-party license involved, that needs to be checked as well. * Is there a test for it that implements the [Thrift test suite|https://github.com/apache/thrift/blob/master/test/ThriftTest.thrift#L141]? > Kotlin code generator? > ---------------------- > > Key: THRIFT-5548 > URL: https://issues.apache.org/jira/browse/THRIFT-5548 > Project: Thrift > Issue Type: New Feature > Components: C++ - Compiler, Java - Compiler, Java - Library > Reporter: Jiayu Liu > Assignee: Jiayu Liu > Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > It'll be useful to create a Kotlin specific code generator that will product > Kotlin code which is based on the existing Java library. > The motivation for a separate Kotlin generator is that: > * some of the language features in Kotlin can largely simplify generated > code in terms of code size and method counts > * implementing a new Kotlin code gen is easier because it can leverage the > existing Java library -- This message was sent by Atlassian Jira (v8.20.1#820001)