nanreh opened a new pull request, #2619:
URL: https://github.com/apache/thrift/pull/2619

   …ator + metadata code
   
   Client: java
   
   The change is trivial: just added a couple of missing calls to 
`get_true_type` in the Java generator so that we get exactly the same code 
regardless of what order structs are defined (specifically structs that refer 
to each other and create forward references). Without this fix, it's possible 
to get different Java from the generator. Specifically, the generator would 
produce incorrect metadata and would exclude validation calls on sub-structs. 
More detail can be found at this test repo I put together to demonstrate the 
issue:
   
   https://github.com/nanreh/thrift_struct_refs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@thrift.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to