mleinart opened a new pull request, #2624: URL: https://github.com/apache/thrift/pull/2624
contrib/fb303 no longer compiles after [THRIFT-4730](https://issues.apache.org/jira/browse/THRIFT-4730) removed ReadWriteMutex. The ReadWriteMutex used by fb303 is protecting counter statistics. These are very write-heavy and read-light (these are read only when the Service methods getCounters() or getCounter() are called). Because of this, retaining a read-write mutex to protect these counters is unjustified and we can safely swap this out for a normal Mutex. Compilation also fails after [THRIFT-5168](https://issues.apache.org/jira/browse/THRIFT-5168) removed generation of *_constants.cpp and *_constants.h generation because the fb303 Makefile explicitly depends on these unnecessary files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
