I've long been wishing to upgrade the rust lib and gen code to latest version and have a pull request up at https://github.com/apache/thrift/pull/2623/files however i do need to fix some generator code that spills out clippy-failing code first...
About the quick fix, i think dropping `--all` flag should be easiest and minimally disruptive to how clippy works? On June 24, 2022, Allen George <allen.geo...@gmail.com> wrote: > Sorry Jens - > > I know I’ve a backlog of Rust stuff to look at. I can take a look. > Just scanning the error text above it sounds like a dependency may > have updated somewhere causing clippy to fail. The immediate > workaround is to remove the clippy call; the more complete one for me > is to take a look and figure out what changed, and why (I’d rather not > disable clippy). > > Allen > ________________________________ > From: Jens Geyer <je...@apache.org> > Sent: Friday, June 24, 2022 3:08:25 AM > To: Thrift-Dev <dev@thrift.apache.org> > Subject: Rust - attributes are not yet allowed on `if` expressions > > Hi, > > fresh day, fresh problems. > > > /root/.cargo/bin/cargo fmt --all -- --check > /root/.cargo/bin/cargo clippy --all -- -D warnings > Compiling libc v0.2.126 > Compiling autocfg v1.1.0 > Compiling log v0.4.17 > Checking cfg-if v1.0.0 > Checking integer-encoding v3.0.4 > error: attributes are not yet allowed on `if` expressions > --> > /root/.cargo/registry/src/github.com-1ecc6299db9ec823/integer- > encoding-3.0.4/src/fixed.rs:57:17 > | > 57 | #[cfg(target_endian = "big")] > | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > ... > 90 | impl_fixedint!(usize); > | ---------------------- in this macro invocation > > > and a whole bunch more like that. > > Anything I could do? Anyone else? > > Full log > https://app.travis-ci.com/github/apache/thrift/jobs/574574155 > > Have fun, > JensG
