kou opened a new pull request, #2630: URL: https://github.com/apache/thrift/pull/2630
<!-- Explain the changes in the pull request below: --> It seems that Apache Thrift wants to drop Boost dependency eventually. See also: https://github.com/apache/thrift/blob/4646a3557b822c3893dc6773882a689118b77611/lib/cpp/CMakeLists.txt#L20-L21 # Remove the following once lib/cpp no longer depends on boost headers: include(BoostMacros) This is a step for it. We don't need to use boost::scoped_array because we can use std::unique_ptr. We require C++11 or later and std::unique_ptr can be used with C++11 or later. <!-- We recommend you review the checklist/tips before submitting a pull request. --> - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes) - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? (not required, but preferred) - [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"? - [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources. <!-- The Contributing Guide at: https://github.com/apache/thrift/blob/master/CONTRIBUTING.md has more details and tips for committing properly. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
