[
https://issues.apache.org/jira/browse/THRIFT-5616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598039#comment-17598039
]
Jens Geyer edited comment on THRIFT-5616 at 8/30/22 8:01 PM:
-------------------------------------------------------------
Easyfix and no patch?
{code}
if events <> nil
then context := events.CreateRequestContext(msg.Name)
else context := nil;
try
fn(msg.SeqID, iprot, oprot, context);
finally
if context <> nil then begin
context.CleanupContext;
context := nil;
end;
end;
{code}
Can you illustrate on the above code what you mean?
was (Author: jensg):
Easyfix and no patch?
> CreateRequestContext never called in the generated TProcessorImpl class
> -----------------------------------------------------------------------
>
> Key: THRIFT-5616
> URL: https://issues.apache.org/jira/browse/THRIFT-5616
> Project: Thrift
> Issue Type: Bug
> Components: Delphi - Compiler
> Affects Versions: 0.16.0
> Reporter: Robert Simon
> Priority: Minor
>
> Under the generated *TProcessorImpl* class *Process* method the events
> received as parameters ({_}const events : IProcessorEvents{_}) never called.
>
> I suggest a solution, (before the *TProcessFunction* call):
> _if Assigned(events) then events.CreateRequestContext(msg.name);_
> _fn(msg.SeqID, iprot, oprot);_
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
