[
https://issues.apache.org/jira/browse/THRIFT-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-5659.
--------------------------------
Fix Version/s: 0.18.0
Resolution: Fixed
> protocol: declare when methods override
> ---------------------------------------
>
> Key: THRIFT-5659
> URL: https://issues.apache.org/jira/browse/THRIFT-5659
> Project: Thrift
> Issue Type: Sub-task
> Components: C++ - Library
> Reporter: Christopher Friedt
> Assignee: Christopher Friedt
> Priority: Trivial
> Fix For: 0.18.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> {{This avoids compiler warnings about inconsistent use of `override` like the
> one below.}}
> {{In file included from
> /Users/cfriedt/workspace/thrift/test/cpp/src/TestServer.cpp:29:}}
> {{/Users/cfriedt/workspace/thrift/lib/cpp/src/thrift/protocol/TJSONProtocol.h:255:8:
> warning: 'checkReadBytesAvailable' overrides a member function but is not
> marked 'override' [-Winconsistent-missing-override]}}
> {{ void checkReadBytesAvailable(TList& list)}}
> {{ ^}}
> {{/Users/cfriedt/workspace/thrift/lib/cpp/src/thrift/protocol/TProtocol.h:563:16:
> note: overridden virtual function is here}}
> {{ virtual void checkReadBytesAvailable(TList& list)}}
> PR is here:
> [https://github.com/apache/thrift/pull/2687]
> See also:
> [https://github.com/zephyrproject-rtos/gsoc-2022-thrift/issues/147]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
