Oh I think I figured it out. In lib/go/Makefile.am, we only add `test` to SUBDIR if WITH_TEST is defined. In github actions we likely didn't define that so that's not included.
On Wed, Oct 12, 2022 at 4:19 PM Yuxuan Wang <yuxuan.w...@reddit.com> wrote: > I have to admit I'm not too familiar with gnu make and how is it supposed > to work. > > When I run `make -C lib/go check` locally, from the output I see it did > `make check` under `lib/go`, and also go into subdirectories to run `make > check` under `lib/go/test` automatically. > > But from our Github actions log (for example > https://github.com/apache/thrift/actions/runs/3238309564/jobs/5306447608, > under "Run make check for lib/go" part), it seems like it only run `make > check` under `lib/go` and did not go into subdirectories of `lib/go/test`. > > I'm not sure if it's a version difference causing a behavior difference > (my local version is "GNU Make 4.3", fwiw), nor if there's an arg to make > sure that it goes into subdirectories. Can someone more familiar with gnu > make help? >
