fishy opened a new pull request, #2724:
URL: https://github.com/apache/thrift/pull/2724
Client: go
The go library itself does not have any third-party dependencies. We have
one third party dependency from the test code, which kind of polluted from
top-level go.mod file to the users of thrift go library.
We previous tried to clean that up by creating go.mod file at lib/go/thrift,
which caused issues to the release process and thus reverted. Now we are at
minimal go 1.18, we can use go workspace to clean it up by making all the tests
their own modules, so the top-level go.mod file is only for the library.
Also some minor fixes on the github actions go workflow.
<!-- Explain the changes in the pull request below: -->
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [ ] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not
required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [ ] Did you squash your changes to a single commit? (not required, but
preferred)
- [ ] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
