[
https://issues.apache.org/jira/browse/THRIFT-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christopher Friedt updated THRIFT-5666:
---------------------------------------
Description:
The <sys/poll.h> header is not actually where poll(2) must be defined according
to the spec. However, it may be the case that some random UNIX-like OS uses
<sys/poll.h> instead.
Both use cases can be supported simply by including the proper header, if it
exists.
See
[https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/poll.h.html]
[https://man7.org/linux/man-pages/man2/poll.2.html]
PR is here
[https://github.com/apache/thrift/pull/2723]
was:
The sys/poll.h header is not actually specified by POSIX and is therefore
nonportable.
It's better to use poll.h
See
[https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/poll.h.html]
[https://man7.org/linux/man-pages/man2/poll.2.html]
PR is here
https://github.com/apache/thrift/pull/2723
> lib: cpp: prefer poll.h over sys/poll.h
> ---------------------------------------
>
> Key: THRIFT-5666
> URL: https://issues.apache.org/jira/browse/THRIFT-5666
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Christopher Friedt
> Assignee: Christopher Friedt
> Priority: Trivial
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The <sys/poll.h> header is not actually where poll(2) must be defined
> according to the spec. However, it may be the case that some random UNIX-like
> OS uses <sys/poll.h> instead.
> Both use cases can be supported simply by including the proper header, if it
> exists.
> See
> [https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/poll.h.html]
> [https://man7.org/linux/man-pages/man2/poll.2.html]
> PR is here
> [https://github.com/apache/thrift/pull/2723]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
