kinoroy opened a new pull request, #2766:
URL: https://github.com/apache/thrift/pull/2766
<!-- Explain the changes in the pull request below: -->
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [x] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
([Request account here](https://selfserve.apache.org/jira-account.html), not
required for trivial changes)
- [x] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but
preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [x] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
## What
Adds unix domain sockets as a low level transport option for the Swift
library
## Why
To improve Swift language support in Thrift
## How
Extend the existing `TSocketServer` with a new initializer, taking a `path`
input to a Unix domain socket path, and connecting to it. A new `UnixSocket`
wrapper class was created for wrapping the different socket implementations in
Linux and macOS.
## Compatibility
All changes are additive or equivalent; there are no breaking changes.
## Testing
Enables `domain` socket tests in the cross-test suite for Swift.
Some cross-tests are failing due to other languages not implementing the
`UUID` type or their implementation doesn't match the spec.
After rebasing on master it seems the cross-tests also seem to not be
running right now in CI due to a failure to build the go library
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
