joemcdonnell opened a new pull request, #2811:
URL: https://github.com/apache/thrift/pull/2811
A recent change modified SecurityTest.cpp/SecurityFromBufferTest.cpp to
handle OpenSSL3 by using OPENSSL_VERSION_MAJOR to detect the different OpenSSL
versions. OPENSSL_VERSION_MAJOR is not available on OpenSSL 1.x, so these tests
no longer compile on Ubuntu 20, etc.
The underlying reason for the OpenSSL3 change is that older versions of TLS
(1.0, 1.1) are only accessible when specifying @SECLEVEL=0. Some distributions
with OpenSSL 1.1.1 (Ubuntu 20) make them accessible at @SECLEVEL=1, so the
tests can also fail in that circumstance.
This removes the reference to OPENSSL_VERSION_MAJOR and changes the test to
specify @SECLEVEL=0 for OpenSSL versions that have @SECLEVEL support (> 1.1.0).
Testing:
- Tested SecurityTest/SecurityFromBufferTest on Ubuntu 20 and 22
- Tested with OpenSSL 1.0.2
<!-- Explain the changes in the pull request below: -->
This fixes the build/functionality for SecurityTest/SecurityFromBufferTest
after the changes in
https://github.com/apache/thrift/commit/05604e261455f1d85a5d04c4364a21d2a7e417b2
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [ ] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
([Request account here](https://selfserve.apache.org/jira-account.html), not
required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [ ] Did you squash your changes to a single commit? (not required, but
preferred)
- [ ] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
