[
https://issues.apache.org/jira/browse/THRIFT-5568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735907#comment-17735907
]
Jens Geyer commented on THRIFT-5568:
------------------------------------
Execution failed for task ':spotlessJavaCheck'.
[21|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:22]>
The following files had format violations:
[22|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:23]
src/main/java/org/apache/thrift/protocol/TBinaryProtocol.java
[23|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:24]
@@ -553,6 +553,7 @@
[24|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:25]
········throw·new·TTransportException(TTransportException.UNKNOWN,·"unrecognized·type·code");
[25|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:26]
····}
[26|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:27]
··}
[27|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:28]
+
[28|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:29]
··//·-----------------------------------------------------------------
[29|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:30]
··//·Additional·methods·to·improve·performance.
[30|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:31]
[31|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:32]
src/main/java/org/apache/thrift/protocol/TCompactProtocol.java
[32|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:33]
@@ -940,6 +940,7 @@
[33|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:34]
········throw·new·TTransportException(TTransportException.UNKNOWN,·"unrecognized·type·code");
[34|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:35]
····}
[35|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:36]
··}
[36|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:37]
+
[37|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:38]
··//·-----------------------------------------------------------------
[38|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:39]
··//·Additional·methods·to·improve·performance.
[39|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:40]
[40|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:41]
src/main/java/org/apache/thrift/server/TThreadedSelectorServer.java
[41|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:42]
@@ -65,18 +65,22 @@
[42|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:43]
[43|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:44]
····/**·The·number·of·threads·for·selecting·on·already-accepted·connections·*/
[44|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:45]
····public·int·selectorThreads·=·2;
[45|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:46]
+
[46|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:47]
····/**
[47|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:48]
·····*·The·size·of·the·executor·service·(if·none·is·specified)·that·will·handle·invocations.·This
[48|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:49]
·····*·may·be·set·to·0,·in·which·case·invocations·will·be·handled·directly·on·the·selector·threads
[49|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:50]
·····*·(as·is·in·TNonblockingServer)
[50|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:51]
·····*/
[51|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:52]
····private·int·workerThreads·=·5;
[52|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:53]
+
[53|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:54]
····/**·Time·to·wait·for·server·to·stop·gracefully·*/
[54|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:55]
····private·int·stopTimeoutVal·=·60;
[55|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:56]
[56|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:57]
····private·TimeUnit·stopTimeoutUnit·=·TimeUnit.SECONDS;
[57|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:58]
+
[58|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:59]
····/**·The·ExecutorService·for·handling·dispatched·requests·*/
[59|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:60]
····private·ExecutorService·executorService·=·null;
[60|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:61]
+
[61|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:62]
····/**
[62|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:63]
·····*·The·size·of·the·blocking·queue·per·selector·thread·for·passing·accepted·connections·to·the
[63|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:64]
·····*·selector·thread
[64|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:65]
src/main/java/org/apache/thrift/transport/TIOStreamTransport.java
[65|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:66]
@@ -68,6 +68,7 @@
[66|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:67]
····super(config);
[67|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:68]
····inputStream_·=·is;
[68|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:69]
··}
[69|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:70]
+
[70|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:71]
··/**
[71|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:72]
···*·Input·stream·constructor,·constructs·an·input·only·transport.
[72|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:73]
... (1 more lines that didn't fit)
[73|https://github.com/apache/thrift/actions/runs/5339040525/jobs/9677303246?pr=2820#step:6:74]
Run './gradlew :spotlessApply' to fix these violations.
> Use spotless gradle plugin and google-java-format to enforce a consistent
> code format
> -------------------------------------------------------------------------------------
>
> Key: THRIFT-5568
> URL: https://issues.apache.org/jira/browse/THRIFT-5568
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library
> Reporter: Liu Jiayu
> Assignee: Liu Jiayu
> Priority: Minor
> Fix For: 0.17.0
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> [https://github.com/diffplug/spotless]
> [https://github.com/google/google-java-format]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
