[
https://issues.apache.org/jira/browse/THRIFT-5725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Prasenjit Sarkar updated THRIFT-5725:
-------------------------------------
Description:
When the Thrift OpenSSL server gets a file descriptor of 0 (which is valid),
the server stops working and cannot accept new connections because of the
following code in TSSLSocket.cpp:
{code:java}
if (BIO_get_fd(bio, &fdSocket) <= 0)
{ throw TSSLException("BIO_get_fd failed"); }
{code}
The fix would be to just change the comparison from <= to <
was:
When the Thrift OpenSSL server gets a file descriptor of 0 (which is valid),
the server stops working and cannot accept new connections because of the
following code in TSSLSocket.cpp:
```
if (BIO_get_fd(bio, &fdSocket) *<=* 0) {
throw TSSLException("BIO_get_fd failed");
}
```
The fix would be to just change the comparison from <= to <
> Thrift SSL server stops working if the file descriptor returned is zero
> -----------------------------------------------------------------------
>
> Key: THRIFT-5725
> URL: https://issues.apache.org/jira/browse/THRIFT-5725
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.19.0
> Reporter: Prasenjit Sarkar
> Priority: Critical
> Fix For: 0.12.0, 0.13.0, 0.15.0, 0.14.2, 0.16.0, 0.17.0, 0.18.1,
> 0.19.0
>
>
> When the Thrift OpenSSL server gets a file descriptor of 0 (which is valid),
> the server stops working and cannot accept new connections because of the
> following code in TSSLSocket.cpp:
>
> {code:java}
> if (BIO_get_fd(bio, &fdSocket) <= 0)
> { throw TSSLException("BIO_get_fd failed"); }
> {code}
>
> The fix would be to just change the comparison from <= to <
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
