[ 
https://issues.apache.org/jira/browse/THRIFT-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775200#comment-17775200
 ] 

Mario Emmenlauer commented on THRIFT-5660:
------------------------------------------

Thanks [~cfriedt] for the immediate response!

I think its nice if you consider a better implementation! However we may also 
want to consider to revert the commit until a better implementation is found. 
It may be better to live with the dependency on boost, rather than breaking one 
of the transports.

What do others think? [~jensg] ? Others?

> TTransportException: create thrift::numeric_cast
> ------------------------------------------------
>
>                 Key: THRIFT-5660
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5660
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: C++ - Library
>            Reporter: Christopher Friedt
>            Assignee: Christopher Friedt
>            Priority: Trivial
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> This adds an equivalent implementation of `boost::numeric_cast` written 
> purely in standard c++.
> The implementation is relatively trivial and reduces the dependency on 
> `boost`.
> Adapted from
> https://stackoverflow.com/a/49658950/5636218
> PR is here:
> [https://github.com/apache/thrift/pull/2689]
> See also:
> [https://github.com/zephyrproject-rtos/gsoc-2022-thrift/issues/147]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to