emmenlau opened a new pull request, #2871: URL: https://github.com/apache/thrift/pull/2871
This reverts commit 6e9cbbd059b00741c886b252cc63d325e4d86e22. Sadly, the implementation of `apache::thrift::numeric_cast()` breaks the `HEADER` protocol in the C++ implementation. Reverting this commit fixes the breakage. See for a discussion. - [x] Jira ticket: https://issues.apache.org/jira/browse/THRIFT-5660 - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? (not required, but preferred) - [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"? - [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
