[ https://issues.apache.org/jira/browse/THRIFT-5753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805774#comment-17805774 ]
Pavel Kvach commented on THRIFT-5753: ------------------------------------- I'll look into checking the code's compatibility with PHP 8.1 in a separate task. I'm not sure about raising the minimum PHP version. This is probably a matter for some kind of general vote. I would probably go up to version 7.4, since it is still in use. > PHP 8.1 deprecated warning about return type in jsonSerialize functions > ----------------------------------------------------------------------- > > Key: THRIFT-5753 > URL: https://issues.apache.org/jira/browse/THRIFT-5753 > Project: Thrift > Issue Type: Bug > Components: PHP - Library > Reporter: Pavel Kvach > Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > In PHP 8.1 a "mixed" return type was added to the > "JsonSerializable::jsonSerialize()" method. > This triggers a deprecation warning for generated PHP classes: > {code:java} > Return type of TestClass::jsonSerialize() should either be compatible with > JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] > attribute should be used to temporarily suppress the notice in ...{code} -- This message was sent by Atlassian Jira (v8.20.10#820010)