adrianhelvikspond opened a new pull request, #2922:
URL: https://github.com/apache/thrift/pull/2922
<!-- Explain the changes in the pull request below: -->
The generated typescript client includes type definitions like this:
```typescript
addProfile(profile: types_ttypes.Profile): Promise<types_ttypes.Profile>;
addProfile(profile: types_ttypes.Profile, callback?: (error: void,
response: types_ttypes.Profile)=>void): void;
```
This is ambigous as the second definition overrides the first one since
callback is optional. And is in fact not how the client works.
The correct types should be:
```typescript
addProfile(profile: types_ttypes.Profile): Promise<types_ttypes.Profile>;
addProfile(profile: types_ttypes.Profile, callback: (error: void,
response: types_ttypes.Profile)=>void): void;
```
My current workaround is to run this nasty sed, so it would be nice to get
this fix in. 😄
```bash
find "$out_dir" -name '*.d.ts' -type f -exec sed -i '' -e
'/.*callback\?:.*/d' {} \;
```
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [ ] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
([Request account here](https://selfserve.apache.org/jira-account.html), not
required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but
preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@thrift.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
