[
https://issues.apache.org/jira/browse/THRIFT-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820168#comment-17820168
]
Paul Wilkinson commented on THRIFT-5712:
----------------------------------------
Thanks for trying out the implementation!
I removed 'TBase.getFieldValue' and 'TBase.setFieldValue' since I could
not get them to work for both nullable and non-nullable fields. These
methods were not present in some of the other languages that I checked.
I think I can implement 'TBase.isSet' but it will have to always return
true for non-optional values since they have to have a value in Dart 3 by
definition.
I will investigate the Uint8List issue.
On Fri, Feb 23, 2024 at 3:33 PM ASF GitHub Bot (Jira) <[email protected]>
> Add Dart 3 compatibility
> ------------------------
>
> Key: THRIFT-5712
> URL: https://issues.apache.org/jira/browse/THRIFT-5712
> Project: Thrift
> Issue Type: Improvement
> Components: Dart - Compiler
> Affects Versions: 0.18.1
> Reporter: Vlad Koronnov
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Dart project generated by thrift has constraints in pubspec.yaml
>
> {code:java}
> name: dart_client
> version: 0.0.1
> description: Autogenerated by Thrift Compiler
> environment:
> sdk: '>=2.12.0 <3.0.0' {code}
>
>
> And generated code uses uninitialized variables, which can't be used with
> sound null safety, required by Dart 3.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
