[
https://issues.apache.org/jira/browse/THRIFT-5757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820296#comment-17820296
]
Jens Geyer edited comment on THRIFT-5757 at 2/24/24 9:51 AM:
-------------------------------------------------------------
{quote}PHP Lib in Thrift project currently supports many PHP versions, which is
EOL, it gives many troubles, because in the new PHP version many changes are
provided and many old possibilities become deprecated.
{quote}
If it is EOL and makes problems why don't we drop support for it from current
development branch?
EDIT: Just found this [https://www.php.net/supported-versions.php]
The 7 version is not even listed there ... however if it is still widely used
and does not cause too many additional troubles to support, why not? I'm fine
with it.
I just would recommend to check the efforts needed and if it gets too clumsy
and troublesome to maintain any outdated version I personally would decide to
cut it off and go with what is officially supported at the moment.
Just to make an example: When net6 (LTS) [gets EOL in
October|https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core]
this year, net6 and net7 support will be the next thing I throw out.
was (Author: jensg):
{quote}
PHP Lib in Thrift project currently supports many PHP versions, which is EOL,
it gives many troubles, because in the new PHP version many changes are
provided and many old possibilities become deprecated.
{quote}
If it is EOL and makes problems why don't we drop support for it from current
development branch?
> Unit tests for php lib
> ----------------------
>
> Key: THRIFT-5757
> URL: https://issues.apache.org/jira/browse/THRIFT-5757
> Project: Thrift
> Issue Type: New Feature
> Components: PHP - Library
> Reporter: Volodymyr Panivko
> Assignee: Volodymyr Panivko
> Priority: Major
> Attachments: image-2024-02-24-10-41-37-836.png
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> After running PHP unit tests for each pull request THRIFT-5756
> Next step is writing test for php lib.
> It will be several pull request for this task.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
