Hello. PHP Lib in Thrift project currently supports many PHP versions, which is EOL, it gives many troubles, because in the new PHP version many changes are provided and many old possibilities become deprecated. Some examples of such errors: https://issues.apache.org/jira/browse/THRIFT-5723 https://issues.apache.org/jira/browse/THRIFT-5758 https://issues.apache.org/jira/browse/THRIFT-5754 https://issues.apache.org/jira/browse/THRIFT-5753
So I offer to remove support of php less than 8.0 My plan is: - add running of unit tests in php lib for every pull request (done https://issues.apache.org/jira/browse/THRIFT-5756) - add full coverage by tests for php lib (start https://issues.apache.org/jira/browse/THRIFT-5757) - remove support of php5 in composer.json and set minimal version to php7.4 ( https://issues.apache.org/jira/browse/THRIFT-5760) - remove scr folder and use only lib as only one source of code - update code for using new features from php7 syntax - update generation of code to new php7 syntax - remove support of php7 in composer.json and set minimal version to php8.1 - update code for using new features from php8 syntax - update generation of code to new php8 syntax - add PSR-12 as code style for project - add check of code style to github actions - add PSR-12 as code style for generated classes Please write your opinion. And I will be very glad if someone will help me with test writing.
