k-walton opened a new pull request, #2946:
URL: https://github.com/apache/thrift/pull/2946
<!-- Explain the changes in the pull request below: -->
The code in `ParseQuotedStringBody()` was recursing in our application
every time there was an escaped quote in strings and generating a new string
buffer for every recursive call. This was a real issue for escaped JSON in our
application in particular.
So this pull requests moves that logic into a loop, and uses a string
builder to avoid re-allocating buffers for every iteration.
We observed an ~40x decrease in p99 latency from 2 seconds -> 50
milliseconds on our servers when implementing this change. So it is a
substantial performance improvement for this particular use case.
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [x] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
([Request account here](https://selfserve.apache.org/jira-account.html), not
required for trivial changes)
- [x] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but
preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [x] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
