ben-harris-5 opened a new pull request, #2950: URL: https://github.com/apache/thrift/pull/2950
<!-- Explain the changes in the pull request below: --> When generating the JS Thrift clients, it hard-codes `this.output` in a few places; however, if `gen_node_` is true, our variable should be `output` instead. We set a variable, `outputVar`, up on line 1968/1970 of the file, but don't use it everywhere. In NodeJS environment, this can lead to the wrong flush being called, which can lead to issues; for example, with the header transport protocol, the headers can either go missing or be sent incorrectly. <!-- We recommend you review the checklist/tips before submitting a pull request. --> I believe this is a trivial change not requiring a ticket. - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? ([Request account here](https://selfserve.apache.org/jira-account.html), not required for trivial changes) - [ ] ~If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?~ - [x] Did you squash your changes to a single commit? (not required, but preferred) - [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"? - [ ] ~If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.~ <!-- The Contributing Guide at: https://github.com/apache/thrift/blob/master/CONTRIBUTING.md has more details and tips for committing properly. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
