fishy opened a new pull request, #2971:
URL: https://github.com/apache/thrift/pull/2971
This reverts commit 344498b67f42af38118cc250b0b1ec212f09d927.
In our extreme case this actually made things worse. On 30s cpu profiles,
although mallocgc reduced from 27.13s to 26.30s, the byte pool itself costed
11.9s. Looking at writeByte and readByte, writeByte increased from 3.69s to
5.89s, and readByte increased from 11.36s to 16.09s.
<!-- Explain the changes in the pull request below: -->
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [ ] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
([Request account here](https://selfserve.apache.org/jira-account.html), not
required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [ ] Did you squash your changes to a single commit? (not required, but
preferred)
- [ ] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@thrift.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
