[jira] [Comment Edited] (THRIFT-5794) Uncompilable C# code in 0.20.0

[Jens Geyer (Jira)]

    [ 
https://issues.apache.org/jira/browse/THRIFT-5794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863946#comment-17863946
 ] 

Jens Geyer edited comment on THRIFT-5794 at 7/8/24 9:33 PM:
------------------------------------------------------------

* Fixed via PR [#2993|https://github.com/apache/thrift/pull/2993] for 0.20.0 
(not released)
 * Fixed via PR [#2966|https://github.com/apache/thrift/pull/2966] for 0.21.0

Thanks to [Sven Roederer|https://github.com/SvenRoederer] for pointing this out 
and providing the 0.20.0 patch.


was (Author: jensg):
* Fixed via PR [#2993|https://github.com/apache/thrift/pull/2993] for 0.20.0
* Fixed via PR [#2966|https://github.com/apache/thrift/pull/2966] for 0.21.0

Thanks to [Sven Roederer|https://github.com/SvenRoederer] for pointing this out 
and providing the 0.20.0 patch.

> Uncompilable C# code in 0.20.0
> ------------------------------
>
>                 Key: THRIFT-5794
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5794
>             Project: Thrift
>          Issue Type: Bug
>          Components: netstd - Compiler
>    Affects Versions: 0.20.0
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>            Priority: Major
>             Fix For: 0.21.0
>
>
> h2. Symptom
> {code}
> namespace * deepcopy_syntax
> struct CIELab
> {
>   1: double L;
>   2: double a;
>   3: double b;
> }
> {code}
> via 
> {code}
> thrift -gen netstd test.thrift
> {code}
> leads to 
> {code}
> public CIELab DeepCopy()
> {
>       var tmp5 = new CIELab()    // <----- here the closing ";" is missing
>       if(__isset.L)
>       {
>               tmp5.L = this.L;
>       }
>       ...
> {code}        
> h2. Affected versions
> * 0.20.0 only



--
This message was sent by Atlassian Jira
(v8.20.10#820010)