[ https://issues.apache.org/jira/browse/THRIFT-5800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yuxuan Wang reassigned THRIFT-5800: ----------------------------------- Assignee: Yuxuan Wang > "Could not find include file foo.thrift" probably should be failure instead > of warning > -------------------------------------------------------------------------------------- > > Key: THRIFT-5800 > URL: https://issues.apache.org/jira/browse/THRIFT-5800 > Project: Thrift > Issue Type: Improvement > Components: Compiler (General) > Reporter: Yuxuan Wang > Assignee: Yuxuan Wang > Priority: Minor > Time Spent: 50m > Remaining Estimate: 0h > > Currently when a thrift file includes a non-exist file and don't reference it > in any way otherwise, like this: > {code} > include "foo.thrift" // does not exist > ... // don't reference anything that's foo.* > {code} > The compiler will generate a warning: > {code} > [WARNING:/path/to/file.thrift:N] Could not find include file foo.thrift > {code} > This probably should be failure instead of warning? Or at least be a failure > when -strict arg is passed in, and keep at warning without -strict. -- This message was sent by Atlassian Jira (v8.20.10#820010)