I created https://github.com/apache/thrift/pull/3020 as a test to see how that works.
That PR also includes changes in https://github.com/apache/thrift/pull/3019, as otherwise the java lib code won't even build. Which I think shows another issue with the spotless check currently: it hides bigger problem that could cause the java lib to stop building, as when spotless check fails we stops CI early and won't know whether the java lib builds. On Wed, Aug 14, 2024 at 9:42 AM Yuxuan Wang <yuxuan.w...@reddit.com> wrote: > From my observation of the past few years, every time the github > dependency bot upgrades the spotless plugin version, it will start to fail > something that passed before. And it usually takes months for someone to > fix those, if they are ever fixed. > > While having some enforcement on styling is great, making those > enforcements to break builds (and also block cross tests from running) for > months is not. If we don't have the resources to keep the styles > up-to-date, then maybe sacrificing some styling in favor of actual cross > tests is a better approach? >
