Hi,
not sure how we want to move on with this.
If there is no further progress until next week, I'm going to cut the
branch anyway. It might not be super cool as it is right now, but OTOH
it also does not look like a real blocker to me.
Have fun,
JensG
Am 22.08.2024 um 09:32 schrieb Xuanwo:
Hi,
I have started a PR for the rust release:
https://github.com/apache/thrift/pull/3027
Welcome to check it out.
Thanks.
On Wed, Aug 21, 2024, at 04:13, Yuxuan Wang wrote:
OK this will be fixed in https://github.com/apache/thrift/pull/3025
On Mon, Aug 19, 2024 at 3:31 PM Yuxuan Wang <yuxuan.w...@reddit.com> wrote:
yea, I suspected the same and tried to remove `sudo` from the previous
step, but that will fail that step instead (pip install without sudo does
not seem to work there)
On Mon, Aug 19, 2024 at 3:29 PM Sven Roederer <s.roede...@colvistec.de>
wrote:
Probably related to "running previous step with sudo"? in build-step
"Run make install for python" the log prints a warning that pip is running
as root. In failing step "Running make check for python" in consequently
not having this warning.
-----Ursprüngliche Nachricht-----
Von: Yuxuan Wang <yuxuan.w...@reddit.com.INVALID>
Gesendet: Montag, 19. August 2024 18:38
An: dev@thrift.apache.org
Betreff: Re: Branch 0.21.0
Hmm, for some reason the Python tests on Github Actions is broken again.
Here is an example:
https://protect.checkpoint.com/v2/___https://github.com/apache/thrift/actions/runs/10457038677/job/289563726___.YzJ1OnJlZGRpdDpjOmc6NTA3NjJjMTAzZjQwYmExNDhkOGUyOWYzNTg4OWMyYTY6NjozYzQzOjAyNzVjZmZiNGU5NWJlYWY4NzJkYjI1NTBlNDNmOGIxNGM0MTk0NTdhNjE1ZTAyNmI2MGUzZGVmOTE5ZmZiYzI6cDpUOk4
19
On the step before I saw it said that it installed six module:
---- 8< ----
...
Successfully built thrift
Installing collected packages: six, thrift Successfully installed
six-1.16.0 thrift-
0.21.0 ...
---- >8 ----
but on the next step, it fails for unable to find six module:
---- 8< ----
...
Traceback (most recent call last):
File "/home/runner/work/thrift/thrift/lib/py/test/thrift_json.py",
line 24, in
<module>
from thrift.protocol.TJSONProtocol import TJSONProtocol
File
"/home/runner/work/thrift/thrift/lib/py/build/lib.linux-x86_64-cpython-
312/thrift/protocol/TJSONProtocol.py",
line 20, in <module>
from .TProtocol import (TType, TProtocolBase, TProtocolException,
File
"/home/runner/work/thrift/thrift/lib/py/build/lib.linux-x86_64-cpython-
312/thrift/protocol/TProtocol.py",
line 24, in <module>
import six
ModuleNotFoundError: No module named 'six'
...
---- >8 ----
Anyone familiar with Python knows what could be the issue?
On Mon, Aug 19, 2024 at 3:51 AM Jens Geyer <jensge...@hotmail.com>
wrote:
Hi all,
I'd like to create a release branch for 0.21.0 in the next days.
Is there anything we should solve before I do that?
Thanks & have fun,
JensG
