sorry, changing my vote to +1 again. we found more small bugs around mypy with new python type hints feature. it doesn't really make sense to block 0.21.0 until we found and fix all those issues, so it's better to target full mypy compatibility on the next release (0.22.0) instead.
On Tue, Sep 17, 2024 at 9:59 AM Yuxuan Wang <yuxuan.w...@reddit.com> wrote: > sorry, changing my vote to -1, found a small bug in the new python hints > feature in 0.21.0: https://github.com/apache/thrift/pull/3040 > > On Tue, Sep 17, 2024 at 9:53 AM Duru Can Celasun <dcela...@apache.org> > wrote: > >> +1 >> >> >> On Tue, 17 Sep 2024, at 17:44, Randy Abernethy wrote: >> > +1 >> > >> > From: *Jens Geyer* <je...@apache.org> >> > Date: Sun, Sep 15, 2024 at 5:32 PM >> > Subject: [VOTE] Apache Thrift 0.21.0-rc0 release candidate >> > To: Thrift-Dev <dev@thrift.apache.org> >> > >> > >> > All, >> > >> > I propose that we accept the following release candidate as the >> official >> > Apache Thrift 0.21.0 release: >> > >> > >> https://protect.checkpoint.com/v2/r01/___https://dist.apache.org/repos/dist/dev/thrift/0.21.0-rc0/thrift-0.21.0.tar.gz___.YzJ1OnJlZGRpdDpjOmc6NmFkZjY1MjM3YjMyMGRlZDRjZWQ0NDc0ZGFjZGFmZGU6NzphZmYxOmExOGJlNGQ5Yzk5NDhlNTdlYzcxOWZiY2I0MDE2YWUyNzYxNzUwMzdiYzNhMzAzYmVkY2FkZWEzMGVkZjIzNGM6cDpUOk4 >> > >> > The release candidate was created from the release/0.21.0 branch and >> can >> > be cloned using: >> > >> > git clone -b release/0.21.0 >> https://protect.checkpoint.com/v2/r01/___https://github.com/apache/thrift.git___.YzJ1OnJlZGRpdDpjOmc6NmFkZjY1MjM3YjMyMGRlZDRjZWQ0NDc0ZGFjZGFmZGU6NzpmMDY4OjBmMjQzMzUwZTFiOGUzMTZhMTEzMmU2Y2VhOGFiMWU3ZGE4MWUxZDIzM2JkNmFlYTczYjUwOWNhOWNhMWIwYmY6cDpUOk4 >> > >> > The release candidates GPG signature can be found at: >> > >> https://protect.checkpoint.com/v2/r01/___https://dist.apache.org/repos/dist/dev/thrift/0.21.0-rc0/thrift-0.21.0.tar.gz.asc___.YzJ1OnJlZGRpdDpjOmc6NmFkZjY1MjM3YjMyMGRlZDRjZWQ0NDc0ZGFjZGFmZGU6Nzo5Njg2OjQ2MWQ4ZDQ5NWRhODJiMGNkM2I1N2UxOWJiZDdmNTI1MTVjZDgwOTdkNDc5MTNlOTk1OGUzYmE3OGM1NDg3NTY6cDpUOk4 >> > >> > The release candidates checksums are: >> > md5: de687816fcde2b91a4dab31b8b02b1cf >> > sha1: 421528bb06dba0349043cbd09930975148eaf822 >> > sha256: 9a24f3eba9a4ca493602226c16d8c228037db3b9291c6fc4019bfe3bd39fc67c >> > >> > >> > >> > A prebuilt Windows compiler is available at: >> > >> https://protect.checkpoint.com/v2/r01/___https://dist.apache.org/repos/dist/dev/thrift/0.21.0-rc0/thrift-0.21.0.exe___.YzJ1OnJlZGRpdDpjOmc6NmFkZjY1MjM3YjMyMGRlZDRjZWQ0NDc0ZGFjZGFmZGU6NzphZWIzOmIwN2EwYzI0ZGZlYTM2YTJlYzNmMTQ0YjM5NjRhZWI5NTIxOGFlNjcwZjllODZjN2NjMDNkODEwYzUwODA2OTU6cDpUOk4 >> > >> > Prebuilt Windows compiler GPG signature: >> > >> https://protect.checkpoint.com/v2/r01/___https://dist.apache.org/repos/dist/dev/thrift/0.21.0-rc0/thrift-0.21.0.exe.asc___.YzJ1OnJlZGRpdDpjOmc6NmFkZjY1MjM3YjMyMGRlZDRjZWQ0NDc0ZGFjZGFmZGU6Nzo0YWViOjk5Yjc5NzkxZGIxZDk3NDBhOTZiOWQ4MDY4YTFmZjFmNzkxOTY2YjkxZWQ2MmZhMzljNjlkYmQ4MjA5MDg1MjQ6cDpUOk4 >> > >> > Prebuilt Windows compiler checksums are: >> > md5: 6f07032378316f4dcda706486a4c1e08 >> > sha1: 88e64781f7d081b37823c5d02f27aa8d4a503543 >> > sha256: e0885da0091e788f2ac9392c54a18ebd2d5526255803ffba10db9a3b4f536f8a >> > >> > >> > >> > >> > The CHANGES list for this release is available at: >> > >> https://protect.checkpoint.com/v2/r01/___https://github.com/apache/thrift/blob/0.21.0/CHANGES.md___.YzJ1OnJlZGRpdDpjOmc6NmFkZjY1MjM3YjMyMGRlZDRjZWQ0NDc0ZGFjZGFmZGU6Nzo0ZWZmOmExMWY0ZjFiNWQyN2E1N2EwNDRkNTIxZTg1M2E4NmY3NTg1ZmRjM2ExOTZiYjMxZmRjMGIzZjNiZGIwODI0MzM6cDpUOk4 >> > >> > >> > Please download, verify sig/sum, install and test the libraries and >> > languages of your choice. >> > >> > >> > I start this voting thread with my own +1 vote. >> > >> > >> > This vote will close in 122 hours on 2024-09-21 00:00 UTC >> > >> https://protect.checkpoint.com/v2/r01/___https://www.timeanddate.com/countdown/generic?iso=20240921T0000&p0=1440___.YzJ1OnJlZGRpdDpjOmc6NmFkZjY1MjM3YjMyMGRlZDRjZWQ0NDc0ZGFjZGFmZGU6Nzo2NjcwOjFkNmYxMjhkNmZmMzAyNmRlNTg5MzBjMjBmMTc4NGRlMDNiMDY5YmY3NGVmMTQxNDY3ZmU5MDYyMGYwZjk3MjA6cDpUOk4 >> > >> > [ ] +1 Release this as Apache Thrift 0.21.0 >> > [ ] +0 >> > [ ] -1 Do not release this as Apache Thrift 0.21.0 because... >> > >> > Have fun, >> > JensG >> > >> > *Attachments:* >> > • OpenPGP_0x76BD340FC4B75865.asc >> > • OpenPGP_signature.asc > >
