[
https://issues.apache.org/jira/browse/THRIFT-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-5850.
--------------------------------
Fix Version/s: 0.22.0
Resolution: Fixed
> Switch IThriftConfiguration interface from Cardinal to Integer
> --------------------------------------------------------------
>
> Key: THRIFT-5850
> URL: https://issues.apache.org/jira/browse/THRIFT-5850
> Project: Thrift
> Issue Type: Improvement
> Components: Delphi - Library
> Reporter: Jens Geyer
> Assignee: Jens Geyer
> Priority: Major
> Fix For: 0.22.0
>
> Attachments:
> 0001-THRIFT-5850-Switch-IThriftConfiguration-interface-fr.patch
>
>
> Delphi (especially older versions) has a tradition of bad detection of
> assignments between unsigned and signed integers and vice versa. The
> developer only rarely gets a warning, in some Delphi versions none at all.
> Hence, although a configuration such as
> {code}
> config := TThriftConfigurationImpl.Create;
> config.MaxMessageSize := value;
> config.MaxFrameSize := value;
> {code}
> might seem to succeed for value > MAXINT at compile time, in reality it
> produces errors at runtime due to a (unsigned) cardinal value being casted
> later on to a negative signed int32.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
