bandle opened a new pull request, #3100:
URL: https://github.com/apache/thrift/pull/3100
<!-- Explain the changes in the pull request below: -->
Affects: TCompactProtocol::readBinary
We allocated the string first and only checked afterward whether this
allocation would be larger than MaxMessageSize allows. Since it throws, we
throw away the buffer and the read, so we should check it earlier.
Furthermore, we check for varint_size + strlen instead of only strlen.
However, since we can read varint using borrow and consume, this already
decreases the remainingMessageSize by varint_size. Thus it can falsely trigger
MaxMessageSize.
The tests for TCompactProtocol now use values closer to the egde case ana
also test for successfull reads instead of only checking for exceptions.
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [x] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
([Request account here](https://selfserve.apache.org/jira-account.html), not
required for trivial changes)
- [x] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but
preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
