[ 
https://issues.apache.org/jira/browse/THRIFT-5858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938165#comment-17938165
 ] 

Zhihua Deng commented on THRIFT-5858:
-------------------------------------

Thank you for the comment, changed this type to MESSAGE_SIZE_LIMIT for this 
case, a draft PR is raised.

> Introduce new type MESSAGE_SIZE_LIMIT in TTransportException
> ------------------------------------------------------------
>
>                 Key: THRIFT-5858
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5858
>             Project: Thrift
>          Issue Type: Bug
>            Reporter: Zhihua Deng
>            Priority: Major
>              Labels: breaking_change
>
> If the transport reads more bytes than the configured max message size, it 
> will throw theĀ 
> the TTransportException with the type TTransportException.END_OF_FILE. This 
> could be a problem when the TThreadPoolServer ignore the exception and kill 
> the connection silently, the client will receive the 'Socket closed by peer' 
> exception, but there is no message in server to tell what's happening.
> In my idea, rather than throwing the exception with END_OF_FILE, we should 
> flag this exception with a new type SIZE_LIMIT.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to