mhlakhani opened a new pull request, #3151: URL: https://github.com/apache/thrift/pull/3151
<!-- Explain the changes in the pull request below: --> This makes a number of changes, following the spec laid out in the ticket. The high level goal is to ensure that these checks are consistent throughout the various implementations. Concretely: * Some implementations checked for numBytes < 0 in the checkReadBytesAvailable() call. Do this everywhere * Always ensure we call checkReadBytesAvailable() with the number of bytes to read, not just container size * The C glib binary protocol was missing some checks the compact protocol had (I just wholesale copied them, replacing 'compact' with 'binary') * Some string length checks weren't consistently applied * getMinSerializedSize() should generally return a minimum of 1, if my understanding of the spec and the context in which it's called in is correct. I made one PR touching all languages, I can split into separate PRs if desired but I figured this gives a more holistic picture of the changes. <!-- We recommend you review the checklist/tips before submitting a pull request. --> - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? ([Request account here](https://selfserve.apache.org/jira-account.html), not required for trivial changes) - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [ ] Did you squash your changes to a single commit? (not required, but preferred) - [ ] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"? - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
