bjosv opened a new pull request, #3161:
URL: https://github.com/apache/thrift/pull/3161
Client: Erlang
- Correcting type info in `thrift_processor` state record.
The '[Support for Multiplexing
Services](https://github.com/apache/thrift/commit/ae971ce)' changed so that the
processor could be initiated with a multiplexed map wrapper. Fixes dialyzer
warnings:
```
src/thrift_processor.erl
Line 52 Column 31: Guard test is_list(HandlerModules::atom()) can never
succeed
Line 66 Column 87: The call
thrift_multiplexed_map_wrapper:fetch(ServiceName::nonempty_string(),
Service::atom()) will never return since the success typing is (any(),
[{_,_},...]) -> any() and the contract is (ServiceHandler, Map) -> Module when
ServiceHandler :: service_handler(), Module :: module(), Map ::
service_handler_map()
```
- Add type information to `thrift_reconnecting_client` state.
The module only handles socket transports, which uses gen_tcp.
Fixes the build warning:
```
===> Compiling thrift
┌─ src/thrift_reconnecting_client.erl:
│
43 │ -record(state, {
│ ╰── Warning: record state has field(s) without type information
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@thrift.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
