[ 
https://issues.apache.org/jira/browse/THRIFT-5871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17956746#comment-17956746
 ] 

Hasnain Lakhani commented on THRIFT-5871:
-----------------------------------------

The first part of this ticket is complete, what's left is this part:

> add some missing ones

> Improve MAX_MESSAGE_SIZE check and friends
> ------------------------------------------
>
>                 Key: THRIFT-5871
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5871
>             Project: Thrift
>          Issue Type: Improvement
>            Reporter: Hasnain Lakhani
>            Assignee: Hasnain Lakhani
>            Priority: Major
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> This is a follow up of https://issues.apache.org/jira/browse/THRIFT-5237
> There's a few things we can do to improve consistency across implementations, 
> and make the checks more internally consistent:
>  * Improve the limits per TType to be more spec conformant
>  * Check the limits after incorporating both container size and element size
>  * Checking string limits against message limits too
>  
> Apply these to all implementations + add some missing ones



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to