zheguang opened a new pull request, #3170:
URL: https://github.com/apache/thrift/pull/3170

   <!-- Explain the changes in the pull request below: -->
   When building from source, `go.mod` is missing the toolchain version, 
resulting in incorrect Makefile generation:
   ```Makefile
   # In Makefile line 747
   golang_version = go: downloading go1.23 (darwin/arm64)
   go: download go1.23 for darwin/arm64: toolchain not available
   ```
   The error can be seen from `go` as well:
   ```bash
   $ go verison
   go: downloading go1.23 (darwin/arm64)
   go: download go1.23 for darwin/arm64: toolchain not available
   ```
   This is due to the separation of the language version and the release 
version of Go [1,2].  
   
   To fix the build, this patch adds the toolchain version `1.23.0`.  
   
   **Testing**
   ```bash
   $ go version
   go version go1.23.0 darwin/arm64
   ```
   
   [1]: https://github.com/golang/go/issues/62278#issuecomment-1693538776
   [2]: https://go.dev/doc/toolchain
   
   <!-- We recommend you review the checklist/tips before submitting a pull 
request. -->
   
   - [ x] Did you create an [Apache 
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  
([Request account here](https://selfserve.apache.org/jira-account.html), not 
required for trivial changes) -- Trivial change
   - [ x ] If a ticket exists: Does your pull request title follow the pattern 
"THRIFT-NNNN: describe my issue"? -- N/A
   - [ x ] Did you squash your changes to a single commit?  (not required, but 
preferred)
   - [ x ] Did you do your best to avoid breaking changes?  If one was needed, 
did you label the Jira ticket with "Breaking-Change"?
   - [ x ] If your change does not involve any code, include `[skip ci]` 
anywhere in the commit message to free up build resources.
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@thrift.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to