Kouhei Sutou created THRIFT-5886:
------------------------------------

             Summary: build/cmake/ should be prepended (not appended) to 
CMAKE_MODULE_PATH
                 Key: THRIFT-5886
                 URL: https://issues.apache.org/jira/browse/THRIFT-5886
             Project: Thrift
          Issue Type: Improvement
          Components: C++ - Library
    Affects Versions: 0.22.0
            Reporter: Kouhei Sutou


https://github.com/apache/thrift/blob/9cff8b9f5b217c143c75299939c32573ccd4c9c3/CMakeLists.txt#L38
 appends {{build/cmake/}} to {{CMAKE_MODULE_PATH}}.

If we build Apache Thrift by {{FetchContent}} 
https://cmake.org/cmake/help/latest/module/FetchContent.html, 
{{CMAKE_MODULE_PATH}} may have some extra paths. If these extra paths have the 
same file name in  https://github.com/apache/thrift/tree/master/build/cmake, 
our files aren't used.

For example, both of Apache Arrow and Apache Thrift have 
{{DefineOptions.cmake}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to