mhlakhani opened a new pull request, #3178: URL: https://github.com/apache/thrift/pull/3178
<!-- Explain the changes in the pull request below: --> Bring the Rust implementation somewhat up to par with the other implementations. I tried 4-5 different ways to get the "perfect" check but since trait specialization is not yet stable, I was not able to arrive at a solution I'm happy with (code was either ugly, or had runtime overhead). So for now, we avoid full message size tracking / more precise limit checking, but this is a strong step in the right direction. Apologies for the large PR - but most of it is boilerplate (configuration) or semi-exhaustive tests. <!-- We recommend you review the checklist/tips before submitting a pull request. --> - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? ([Request account here](https://selfserve.apache.org/jira-account.html), not required for trivial changes) - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? (not required, but preferred) - [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"? - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
