[ 
https://issues.apache.org/jira/browse/THRIFT-5894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18021262#comment-18021262
 ] 

Will Ayd commented on THRIFT-5894:
----------------------------------

OK after looking more closely I believe the conda piece is a red herring and 
this applies to Windows in general. Looking at the CMake macro for adding a 
thrift library, it intentionally suffixes the library name:

[https://github.com/apache/thrift/blob/37c7910072de4bf282f95f7c64f91155d6f2ce7e/build/cmake/ThriftMacros.cmake#L30]

However, the corresponding pkg-config template does not take this into account:

[https://github.com/apache/thrift/blob/37c7910072de4bf282f95f7c64f91155d6f2ce7e/lib/cpp/thrift.pc.in#L28]

My Windows knowledge is admittedly not the best, but do you know why there is a 
need to add the suffix there? It could certainly be my ignorance, but I haven't 
run into that with other libraries before

> pkg-config files distributed via conda on Windows do not link to proper 
> libraries
> ---------------------------------------------------------------------------------
>
>                 Key: THRIFT-5894
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5894
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.22.0
>            Reporter: Will Ayd
>            Priority: Major
>
> When installing Thrift via conda on windows, the pkgconfig files provide 
> lines like:
> ```
> Libs: -L${libdir} -lthrift
> ```
> However, the library that gets distributed actually has the name 
> thriftmd.lib, so when using this to compile a program you get an error that 
> the library `thrift.lib` cannot be found during linkage (the issue also 
> applies to thrift-nb and thrif-z)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to