kpumuk opened a new pull request, #3311:
URL: https://github.com/apache/thrift/pull/3311
<!-- Explain the changes in the pull request below: -->
Since Travis migration, static code analysis job was never migrated to
GitHub actions. I am looking to bring it over (and add Rubocop there for Ruby
library), but need to address the offences first.
Old script used to run the following tests:
* `cppcheck` for cpp and c_glib
* `flake8` for Python (PR is coming up)
* `phpcs` for PHP
This PR fixes C++ issues:
```
/tmp/t_c_glib_generator.before.cc:80:43: warning: If memory allocation
fails, then there is a possible null pointer dereference: tmp
[nullPointerOutOfMemory]
for (unsigned int i = 0; i < strlen(tmp); i++) {
^
/tmp/t_c_glib_generator.before.cc:79:25: note: Assuming allocation function
fails
char* tmp = strdup(this->nspace.c_str());
/tmp/TFileTransportTest.before.cpp:73:22: error: Uninitialized variable:
call.fd [uninitvar]
calls_.push_back(call);
^
```
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [ ] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
([Request account here](https://selfserve.apache.org/jira-account.html), not
required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but
preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
