[ 
https://issues.apache.org/jira/browse/THRIFT-5308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18039522#comment-18039522
 ] 

Dmytro Shteflyuk edited comment on THRIFT-5308 at 3/12/26 1:10 AM:
-------------------------------------------------------------------

-Seems to be addressed in [https://github.com/apache/thrift/pull/2272] and can 
be closed-

After a careful review, the issue is not at all closed. The "fix" checks that 
the reply seqid matches the request seqid, and both are always 0. It also 
introduces typos like 'faild' and 'sqeid'


was (Author: kpumuk):
-Seems to be addressed in [https://github.com/apache/thrift/pull/2272] and can 
be closed-

After a careful review, the issue is not at all closed. The "fix" checks that 
the reply seqid matches the request sequi, and both are always 0. It also 
introduces typos like 'faild' and 'sqeid'

> implement ruby seq reply 
> -------------------------
>
>                 Key: THRIFT-5308
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5308
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Ruby - Compiler, Ruby - Library
>            Reporter: Zezeng Wang
>            Assignee: Zezeng Wang
>            Priority: Minor
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> implement this todo
> {code}
> // TODO(mcslee): Validate message reply here, seq ids etc.
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to