kpumuk opened a new pull request, #3409:
URL: https://github.com/apache/thrift/pull/3409
<!-- Explain the changes in the pull request below: -->
MSVC Docker image is 8.8GiB and takes 20-30 minutes to pull from registry.
Some of the layers include software installation packages, some documentation,
extracted MSIs, chocolatey caches. There seem to be a lot of opportunity to
reduce the size.
* before: `ghcr.io/apache/thrift-build:msvc-d5d97583f97d`
9,511,251,810 bytes
8.86 GiB
* after: `ghcr.io/kpumuk/thrift-build:msvc-f2db224329b8`
6,986,460,516 bytes
6.51 GiB
* Delta:
-2,524,791,294 bytes
-2.35 GiB
-26.5%
Base/custom split:
* First 9 layers are identical in both images: 4,224,296,837 bytes (3.93 GiB)
* Custom build layers:
* before: **5,286,954,973 bytes (4.92 GiB)**
* after: **2,762,163,679 bytes (2.57 GiB)**
* delta: **-2.35 GiB (-47.8%)**
### Comparison per layer(s)
| Step | Before layers | Before MiB | After layers | After
MiB | Delta MiB |
|-----------------------|---------------:|------------:|--------------:|-----------:|---:|
| Shell/init | 10 | 0.0 | 10-11 | 0.4
| +0.4 |
| VS Build Tools | 11-13 | 2248.9 | 12 | 1466.8
| -782.1 |
| CMake | 14-15 | 104.8 | 13 | 63.5
| -41.3 |
| Boost | 16-18 | 653.1 | 14-16 | 293.2
| -360.0 |
| Chocolatey bootstrap | 19 | 22.4 | 17-18 | 22.4
| -0.0 |
| winflexbison3 | 20 | 3.1 | 19 | 3.1
| -0.0 |
| 7zip + curl | 21 | 33.8 | 20 | 33.8
| -0.0 |
| libevent | 22-25 | 2.1 | 21-24 | 2.0
| -0.1 |
| zlib | 26-29 | 1.4 | 25-28 | 1.4
| -0.0 |
| OpenSSL | 30-31 | 559.2 | 29 | 105.1
| -454.1 |
| Java (jdk8) | 32 | 609.2 | 30 | 376.7
| -232.4 |
| Python + setuptools | 33-34 | 671.7 | 31 | 133.5
| -538.1 |
| Node.js | 35 | 132.3 | 32 | 132.3
| -0.0 |
| Entrypoint/Cmd | 36-37 | 0.0 | 33-34 | 0.0
| +0.0 |
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [x] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
[THRIFT-5952](https://issues.apache.org/jira/browse/THRIFT-5952)
- [x] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but
preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
