CJCombrink opened a new pull request, #3431:
URL: https://github.com/apache/thrift/pull/3431
Remove another boost header include from the public API
- It is only used in THeaderTransport.cpp so move it there without
complicating it
- It throws a TTransportException so it should not be used in other code
- People that depends on this can use `boost::numeric_cast` or std::in_range
instead
- The usage in the unit test was not needed since `std::string::size()`
returns an `unsigned long` on 64 compilers
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [x] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
[THRIFT-5785](https://issues.apache.org/jira/browse/THRIFT-5785)
- [x] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [ ] Did you squash your changes to a single commit? (not required, but
preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
