kpumuk commented on code in PR #21: URL: https://github.com/apache/thrift-website/pull/21#discussion_r3177229852
########## _includes/footer.html: ########## @@ -1,32 +1,133 @@ -<div class="container"> - <hr> - <footer class="footer"> - <div class="row"> - <div class="span3"> - <h3>Links</h3> - <ul class="unstyled"> - <li><a href="/download">Download</a></li> - <li><a href="/developers">Developers</a></li> - <li><a href="/tutorial">Tutorials</a></li> - </ul> - <ul class="unstyled"> - <li><a href="/sitemap">Sitemap</a></li> - </ul> +<footer class="footer"> + <div class="inner py-xl"> + <div class="flex gap mb-lg flex-col md:flex-row"> + <div class="flex-1 flex flex-col gap"> + <img + src="/static/images/asf_logo_full_horizontal_white.svg" + width="300" + alt="ASF White Logo" + /> + <p> + Apache, Apache Thrift and the Apache logo are trademarks of + <a href="https://www.apache.org";>The Apache Software Foundation</a> + </p> </div> - <div class="span3"> - <h3>Get Involved</h3> - <ul class="unstyled"> - <li><a href="/mailing">Mailing Lists</a></li> - <li><a href="{{ site.jira_url }}">Issue Tracking</a></li> - <li><a href="/docs/HowToContribute">How To Contribute</a></li> - </ul> - </div> - <div class="span6"> - <a href="http://www.apache.org/";><img src="/static/images/feather.svg" onerror="this.src='/static/images/feather.png';this.onerror=null;" width="32" /></a> - Copyright © {{ 'now' | date: "%Y" }} <a href="http://www.apache.org/";>Apache Software Foundation</a>. - Licensed under the <a href="http://www.apache.org/licenses/";>Apache License v2.0</a>. - Apache, Apache Thrift, and the Apache feather logo are trademarks of The Apache Software Foundation. + <div class="flex-1 flex gap-medium"> + <div class="flex flex-col flex-1"> + <div class="footer-nav-group"> + <h5>Resources</h5> + <ul class="list-unstyled" role="menu"> + <li role="none"> + <a role="menuitem" href="/docs">Docs</a> + </li> + <li role="none"> + <a href="/tutorial">Guides</a> + </li> + <li role="none"> + <a role="menuitem" href="/download">Download</a> + </li> + <li role="none"> + <a role="menuitem" href="/changelog">Changelog</a> + </li> + <li role="none"> + <a role="menuitem" href="/lib">Libraries</a> Review Comment: `/lib`, `/docs` and `/tutorial` render a 301 permanent redirect to a page with trailing `/` ```bash $ curl -D- https://thrift.apache.org/tutorial HTTP/2 301 server: Apache location: https://thrift.apache.org/tutorial/ ``` Might as well fix in the layout to avoid redirects ########## _layouts/default.html: ########## @@ -10,6 +10,9 @@ <link href="/static/css/rouge.css" rel="stylesheet" type="text/css" /> <link href="/static/css/bootstrap.css" media="screen, projection" rel="stylesheet" type="text/css" /> <link href="/static/css/thrift.css" media="screen, projection" rel="stylesheet" type="text/css" /> + <link href="/static/css/new-fonts.css" rel="stylesheet" type="text/css" /> Review Comment: The toolbar is repainting with fallback fonts because `new-fonts.css` is loaded late and uses `font-display: swap`, which causes weird flickering of the navigation bar. I would preload the critical above-the-fold fonts, and load `new-fonts.css` before the legacy stylesheets, and use `font-display: fallback`. ```html <link href="/static/images/favicon.png" rel="shortcut icon" /> <link rel="preload" href="/static/fonts/OpenSans-Regular.ttf" as="font" type="font/ttf" crossorigin /> <link rel="preload" href="/static/fonts/JTUHjIg1_i6t8kCHKm4532VJOt5-QNFgpCu173w5aX8.ttf" as="font" type="font/ttf" crossorigin /> <link rel="preload" href="/static/fonts/Montserrat-ExtraBold.ttf" as="font" type="font/ttf" crossorigin /> <link href="/static/css/new-fonts.css" rel="stylesheet" type="text/css" /> <link href="/static/css/style.css" rel="stylesheet" type="text/css" /> ``` And CSS: ```css /* font-display: swap; */ font-display: fallback; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
