Volodymyr Panivko created THRIFT-6008:
-----------------------------------------
Summary: Add regression tests for recent PHP fixes (UUID exception
fields, readBool container state, popContext underflow)
Key: THRIFT-6008
URL: https://issues.apache.org/jira/browse/THRIFT-6008
Project: Thrift
Issue Type: Improvement
Components: PHP - Library
Reporter: Volodymyr Panivko
Add targeted unit tests guarding three recently-fixed bugs whose code paths had
no direct test coverage:
1. THRIFT-6001: TException::tmethod previously missing TType::UUID, so
UUID-typed fields in exception structs fell through to the recursive STRUCT
path. Add a UUID round-trip case to TestRichException and
TExceptionTest::writeAndReadFieldDataProvider.
2. THRIFT-5987: TCompactProtocol::readBool in STATE_CONTAINER_READ routed
through readByte with a wrong-typed by-ref before the fix. Add a direct unit
test asserting the state-machine path returns the correct bool value.
3. THRIFT-6000/5999: TJSONProtocol::popContext underflow now falls back to a
default BaseContext rather than null, satisfying the non-null property type.
Add a test that explicitly exercises this path.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)