Jens-G opened a new pull request, #3511: URL: https://github.com/apache/thrift/pull/3511
## Summary - Removes `html-validator-cli` from the root `package.json` devDependencies. - This package (last published in 2015) depends on `[email protected]`, which in turn depends on the deprecated `request` package. This chain pulls in outdated transitive dependencies including `[email protected]`, `form-data`, and `qs`. - The only consumer was the `check-local` target in `test/Makefile.am`, which called the W3C remote HTML validation API. That target is not exercised in GitHub CI (the autotools full-tree `make check` runs only in `build/docker/scripts/autotools.sh`, which is not wired into the CI workflow). - The `if WITH_NODEJS` conditional in `test/Makefile.am` is now unnecessary. The two branches are collapsed into a single unconditional rule that retains the compiler's HTML generation smoke-test (`thrift --gen html`). - Regenerated `package-lock.json` to remove the abandoned package and its transitive dependency tree (617 lines removed). ## License No new dependencies introduced. Removal only. ## Test plan - [ ] Root `package.json` no longer references `html-validator-cli` - [ ] `package-lock.json` no longer contains `html-validator`, `html-validator-cli`, or `request` entries - [ ] `test/Makefile.am` still generates HTML via `thrift --gen html` in the unconditional `check-local` target - [ ] GitHub CI (`lib-nodejs` job) is unaffected — it runs `make -C lib/nodejs check`, not `make -C test check` 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
