[ https://issues.apache.org/jira/browse/THRIFT-1209 ]
Volodymyr Panivko deleted comment on THRIFT-1209:
-------------------------------------------
was (Author: sveneld):
Resolved by two independent refactors:
1. **THRIFT-5956** bumped the minimum PHP version to 8.1. Since PHP 7.1,
reserved identifiers (except `class`) are permitted as class constants, so
`public const GLOBAL = 1;` now parses without error.
2. The PHP generator emits properly namespaced output (`namespace metastore;
final class HiveObjectType { ... }`), replacing the legacy `final class
metastore_HiveObjectType` shape shown in the original report.
Verified on current `master` (a2eb3905c): a thrift file containing `enum
HiveObjectType { GLOBAL = 1, DATABASE = 2, ... }` generates a clean namespaced
class with `public const GLOBAL = 1;`, which is valid PHP 8.1+. Suggest closing
as Fixed.
> PHP compiler generates syntax error when for enums containing constant
> "GLOBAL"
> -------------------------------------------------------------------------------
>
> Key: THRIFT-1209
> URL: https://issues.apache.org/jira/browse/THRIFT-1209
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Compiler
> Affects Versions: 0.6.1
> Reporter: Nicholas Telford
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Reported on IRC:
> If an interface calls for an enum that defines a constant that's an invalid
> identifier in PHP (e.g. "GLOBAL") the generated code contains a syntax error.
> Example, from the Hive Metastore Thrift interface:
> {code}
> enum HiveObjectType {
> GLOBAL = 1,
> DATABASE = 2,
> TABLE = 3,
> PARTITION = 4,
> COLUMN = 5,
> }
> {code}
> Generates the following PHP:
> {code}
> final class metastore_HiveObjectType {
> const GLOBAL = 1;
> const DATABASE = 2;
> const TABLE = 3;
> const PARTITION = 4;
> const COLUMN = 5;
> static public $__names = array(
> 1 => 'GLOBAL',
> 2 => 'DATABASE',
> 3 => 'TABLE',
> 4 => 'PARTITION',
> 5 => 'COLUMN',
> );
> }
> {code}
> I suggest we prefix enum constants to avoid this situation, although this
> would mean the interface didn't match.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
