+1 (non-bindning)

Verified on macOS 27 (arm64) and Windows Server 2025 (GitHub Actions):
- sha256 and GPG signature of the tarball and the exe OK, key
8CD87F18...C4B75865 in KEYS
- tarball matches release/0.25.0 (27e8a425f)
- configure + make; lib/go, test/go, tutorial/go, lib/cpp and lib/py checks
pass on macOS, and the go/py cross-tests pass
- lib/go also builds for linux/386 and linux/arm
- Windows: compiler builds from the tarball (x64 and Win32), ctest passes;
go test ./lib/go/thrift/... and the netstd tests pass, the latter with code
generated by thrift-0.25.0.exe
- thrift-0.25.0.exe generates the same code as a Win32 compiler built from
the tarball, except uuid constants in js:node (THRIFT-6336, fixed for
0.26.0)

Downstream:
- my hms-client-go on the RC runtime, both with its 0.24.0-generated code
and with code regenerated by the RC compiler: tests pass, and its
integration matrix against Hive 2.3.9, 3.1.3, 4.0.1 and 4.2.1 (binary,
HTTP, TLS, Kerberos) is green
- Go code generated by the RC compiler for the Hive metastore, TCLIService,
Parquet, Impala, Doris, StarRocks and Evernote IDL builds against lib/go

Things I had to work around on macOS, none of which would hold the release:
- THRIFT-6377: generated C++ for a list<bool> field no longer compiles as
C++11 against libc++ ("no member named 'emplace_back' in
'std::vector<bool>'"; C++14 and later are fine). Came in with ca676787c.
- THRIFT-6378: lib/cpp/test and test/cpp do not pass the OpenSSL and
libevent paths, so the tests do not build when those live outside the
default search path (Homebrew).
- THRIFT-6379: configure.ac and test/cpp hard-code libboost_system, which
Boost 1.89+ no longer ships.
- THRIFT-6385: one TNonblockingServerTest case always fails on macOS, where
RLIMIT_AS cannot be set. Test only.

Found along the way, not new in 0.25.0: THRIFT-6384, the Go -remote stub
does not compile for container arguments whose field id differs from their
position (IoTDB's IDL hits it).

For the next release: the tarball contains lib/d/src/base.o, config.h and
configured Makefiles from the build tree (THRIFT-6380), and md5/sha1 files
can be dropped in favour of sha512 (THRIFT-6381).
Fixes are up as PRs #3957 to #3961.

Sylwester

On Thu, Sep 24, 2026 10:10 PM, Jens Geyer <[email protected]> wrote:

> All,
>
> I propose that we accept the following release candidate as the official
> Apache Thrift 0.25.0 release:
>
>
> https://dist.apache.org/repos/dist/dev/thrift/0.25.0-rc1/thrift-0.25.0.tar.gz
>
> The release candidate was created from the release/0.25.0 branch and can
> be cloned using:
>
> git clone -b release/0.25.0 https://github.com/apache/thrift.git
>
> The release candidates GPG signature can be found at:
>
> https://dist.apache.org/repos/dist/dev/thrift/0.25.0-rc1/thrift-0.25.0.tar.gz.asc
>
> The release candidates checksums are:
> md5: 997be28417384ba5efbaaea7175ae38c
> sha1: 66460125e154344796f921f8bbb79e49260335da
> sha256: 66da4707214c54c94bac082103dc67adaf9e08925662700f269170a7b534b214
>
>
> A prebuilt Windows compiler is available at:
> https://dist.apache.org/repos/dist/dev/thrift/0.25.0-rc1/thrift-0.25.0.exe
>
> Prebuilt Windows compiler GPG signature:
>
> https://dist.apache.org/repos/dist/dev/thrift/0.25.0-rc1/thrift-0.25.0.exe.asc
>
> Prebuilt Windows compiler checksums are:
> md5: ec8e73651f2d84b0b55f8d4a58fdc76d
> sha1: 1819902addb78a45d22a70504462d615850fff5f
> sha256: 9e1cb466141428a60a78aa944e85f901da60d25eb5ed00c8a40c4da5742af08e
>
>
> The CHANGES list for this release is available at:
> https://github.com/apache/thrift/blob/release/0.25.0/CHANGES.md
>
>
> Please download, verify sig/sum, install and test the libraries and
> languages of your choice.
>
> I start this voting thread with my own +1 vote.
>
> This vote will close in 123 hours on 2026-09-30 00:00 UTC
> https://www.timeanddate.com/countdown/generic?iso=20260930T0000&p0=1440
>
> [ ] +1 Release this as Apache Thrift 0.25.0
> [ ] +0
> [ ] -1 Do not release this as Apache Thrift 0.25.0 because...
>
> Have fun,
> JensG
>
>

Reply via email to